Skip to content

Comments

[Controls] Small visual fixes #225430

Merged
mbondyra merged 2 commits intoelastic:mainfrom
mbondyra:dsh/fix_controls_labels
Jun 26, 2025
Merged

[Controls] Small visual fixes #225430
mbondyra merged 2 commits intoelastic:mainfrom
mbondyra:dsh/fix_controls_labels

Conversation

@mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Jun 26, 2025 •
edited by kibanamachine
Loading

Summary

Fixes #221140
Fixes #223579

🏷️ Long labels no longer truncated

Label truncation was introduced sometime between versions 8.14 and 8.18:

8.14 (working):
8.14

8.18 (broken):
8.18

✅ After the fix:
After fix

🎛️ [Controls] Options list hover background fix

The original hover style comes from EUI. Removing it entirely made the interaction feel unclear,
so I’ve reintroduced a lighter background to subtly indicate the hover state:

9.0 (broken):
Screenshot 2025-06-26 at 14 05 51

✅ After the fix:
Hover state

@mbondyra mbondyra requested a review from a team as a code owner June 26, 2025 10:52
@mbondyra mbondyra added release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v9.1.0 v8.19.0 labels Jun 26, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 26, 2025

Pinging @elastic/kibana-presentation (Team:Presentation)

@mbondyra mbondyra added the backport:version Backport to applied version labels label Jun 26, 2025
@mbondyra mbondyra changed the title [Controls] Long labels are no longer truncated fix [Controls] Small visual fixes Jun 26, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 26, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 470.3KB 470.2KB -20.0B

ThomThomson
ThomThomson approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Looked through the code and ran locally, nice small cleanup!

@mbondyra mbondyra merged commit 26d56b5 into elastic:main Jun 26, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 26, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15905805775

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 26, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- [Controls] migrate scss to emotion (#216413)

Manual backport

To create the backport manually run:

node scripts/backport --pr 225430

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Jun 26, 2025
Merged
9 tasks
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 30, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 30, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225430 locally
cc: @mbondyra

4 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 1, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225430 locally
cc: @mbondyra

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 2, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225430 locally
cc: @mbondyra

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 3, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225430 locally
cc: @mbondyra

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 4, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225430 locally
cc: @mbondyra

@ThomThomson ThomThomson removed v8.19.0 backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jul 7, 2025
@ThomThomson
Copy link
Contributor

ThomThomson commented Jul 7, 2025

@mbondyra I've removed the 8.19 backport label from this, as it seems like it won't be backported.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 8, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 8, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225430 locally
cc: @mbondyra

@ThomThomson ThomThomson removed v9.1.0 backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels labels Jul 8, 2025
@ThomThomson ThomThomson added the backport:skip This PR does not require backporting label Jul 8, 2025
@mbondyra mbondyra added the v9.1.0 label Jul 9, 2025
@mbondyra mbondyra deleted the dsh/fix_controls_labels branch July 9, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Controls] Options list loses its background colour on hover [Controls] Long labels are no longer truncated

4 participants

@mbondyra @elasticmachine @kibanamachine @ThomThomson